Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate extension cop versions when rubocop -V #9356

Commits on Jan 8, 2021

  1. Fix duplicate extension cop versions when rubocop -V

    Follow rubocop#9349 (comment).
    
    This PR fixes duplicate extension cop versions when `rubocop -V`.
    
    The following is an example:
    
    ```yaml
    # ext.yml
    require:
      - rubocop-rspec
    
    # .rubocop.yml
    inherit_from: ext.yml
    require:
      - rubocop-performance
      - rubocop-rspec
    
    ## Before
    
    If there are duplicate requires, extension cop display will also be duplicated.
    Duplicate requires will be displayed in duplicate.
    
    ```console
    % rubocop -V
    1.8.0 (using Parser 3.0.0.0, rubocop-ast 1.4.0, running on ruby 2.7.2 x86_64-darwin19)
      - rubocop-performance 1.9.2
      - rubocop-rspec 2.0.0
      - rubocop-rspec 2.0.0
    ```
    
    ## After
    
    Even if there are duplicate requires, they will only be displayed once per extension cop.
    
    ```console
    % rubocop -V
    1.8.0 (using Parser 3.0.0.0, rubocop-ast 1.4.0, running on ruby 2.7.2 x86_64-darwin19)
      - rubocop-performance 1.9.2
      - rubocop-rspec 2.0.0
    ```
    koic committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    9bc1085 View commit details
    Browse the repository at this point in the history