Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9316] Make Style/EmptyLiteral not register offense when using a numbered block #9318

Merged
merged 1 commit into from
Jan 3, 2021

Conversation

agargiulo
Copy link
Contributor

Fixes #9316

Hash.new { _1[_2] = [] } is valid code but the cop was not parsing the
numblock correctly when parsing ruby27. Now it treats both the above and
Hash.new { |h, k| h[k] = [] }
as valid statements.

Update the parsing in Style/EmptyLiteral#hash_with_block to account for numblocks in addition to regular block


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…n using a numbered block

`Hash.new { _1[_2] = [] }` is valid code but the cop was not parsing the
numblock correctly when parsing ruby27. Now it treats both the above and
`Hash.new { |h, k| h[k] = [] }`
as valid statements.
@koic koic merged commit a408b5b into rubocop:master Jan 3, 2021
@koic
Copy link
Member

koic commented Jan 3, 2021

Thanks!

@agargiulo agargiulo deleted the style/empty_literal_hash_fix branch January 3, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/EmptyLiteral seems to want to repalce valid code with invalid code
2 participants