[Fix #9304] Do not register offense for Style/ExplicitBlockArgument when the yield arguments are not an exact match with the block arguments.
#9310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvandersluis
force-pushed
the
issue/9304
branch
2 times, most recently
from
219f151
to
d68ffdc
Compare
bbatsov
reviewed
Dec 31, 2020
dvandersluis
force-pushed
the
issue/9304
branch
from
d68ffdc
to
fab4156
Compare
koic
reviewed
Jan 1, 2021
dvandersluis
force-pushed
the
issue/9304
branch
from
fab4156
to
d3953f0
Compare
…kArgument` when the `yield` arguments are not an exact match with the block arguments.
dvandersluis
force-pushed
the
issue/9304
branch
from
d3953f0
to
3ef4f0f
Compare
|
@bbatsov I think we can include this in the bug fix release, what do you think? |
|
Consider it included! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the block arguments and yield arguments are not an exact match, no offense is raised. Fixes #9304.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.