Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI against Ruby 3.0 #9302

Merged
merged 1 commit into from
Dec 29, 2020
Merged

CI against Ruby 3.0 #9302

merged 1 commit into from
Dec 29, 2020

Conversation

koic
Copy link
Member

@koic koic commented Dec 29, 2020

Follow #9288.

Ruby 3.0.0 has been released and this Ruby version is available on circleci/ruby:3.0 image.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Follow rubocop#9288.

Ruby 3.0.0 has been released and this Ruby version is available on
`circleci/ruby:3.0` image.

- https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/
- https://hub.docker.com/r/circleci/ruby/tags/
@koic koic merged commit 5ec7718 into rubocop:master Dec 29, 2020
@koic koic deleted the ci_against_ruby_30 branch December 29, 2020 02:19
@koic
Copy link
Member Author

koic commented Dec 29, 2020

I enabled Ruby 3.0 CI matrix to required status checks to pass before merging on this repo.

@thbar
Copy link

thbar commented Dec 29, 2020

I am curious about why you did not use the next-generation convenience images provided by CircleCI (so cimg/ruby instead of circleci/ruby).

These new images are supposed to be more stable over time and also have faster spin-up time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants