[Fix #9290] Fix a false positive for Layout/SpaceBeforeBrackets
#9291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_false_positive_for_layout_space_before_brackets
branch
3 times, most recently
from
deb58e2
to
dd773a0
Compare
bbatsov
reviewed
Dec 27, 2020
Fixes rubocop#9290. This PR fixes a false positive for `Layout/SpaceBeforeBrackets` when using array literal argument for method call. If receiver is a method call, it is difficult to prevent false positives. Therefore, This PR change behaviour to detect only when receiver is a variable. As a result, safe detection is possible.
koic
force-pushed
the
fix_false_positive_for_layout_space_before_brackets
branch
from
dd773a0
to
3dd743b
Compare
|
Thanks! |
8 tasks
This was referenced Dec 29, 2020
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Jan 9, 2021
This cop should work with RuboCop 1.8 which includes rubocop/rubocop#9291 ```ruby $ bundle exec rubocop -a Inspecting 71 files ...........................C........................................... Offenses: lib/active_record/connection_adapters/oracle_enhanced_adapter.rb:495:39: C: [Corrected] Layout/SpaceBeforeBrackets: Remove the space before the opening brackets. @do_not_prefetch_primary_key [table_name] = do_not_prefetch = !has_primary_key?(table_name, owner, desc_table_name) ^ 71 files inspected, 1 offense detected, 1 offense corrected Tip: Based on detected gems, the following RuboCop extension libraries might be helpful: * rubocop-rake (http://github.com/rubocop-hq/rubocop-rake) * rubocop-rspec (http://github.com/rubocop-hq/rubocop-rspec) You can opt out of this message by adding the following to your config (see https://docs.rubocop.org/rubocop/extensions.html#extension-suggestions for more options): AllCops: SuggestExtensions: false $ ``` Refer rubocop/rubocop#9305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9290.
This PR fixes a false positive for
Layout/SpaceBeforeBracketswhen using array literal argument for method call.If receiver is a method call, it is difficult to prevent false positives.
Therefore, This PR change behaviour to detect only when receiver is a variable.
As a result, safe detection is possible.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.