[Fix #9160] Fix an incorrect auto-correct for Style/SoleNestedConditional
#9195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dConditional` Fixes rubocop#9160. This PR fixes an incorrect auto-correct for `Style/IfUnlessModifier` and `Style/SoleNestedConditional` when auto-correction conflicts for guard condition.
|
Thanks! |
koic
deleted the
fix_an_incorrect_autocorrect_for_sole_nested_conditional
branch
koic
added a commit
to koic/rubocop
that referenced
this pull request
Aug 15, 2022
…dConditional` Fixes rubocop#10920. This PR fixes an incorrect autocorrect for `Style/SoleNestedConditional` when using nested conditional and branch contains a comment. It removes `return if config.for_cop('Style/IfUnlessModifier')['Enabled']` that introduced in rubocop#9195. That logic is now unnecessary due to rubocop@3fea162 change.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9160.
This PR fixes an incorrect auto-correct for
Style/IfUnlessModifierandStyle/SoleNestedConditionalwhen auto-correction conflicts for guard condition.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.