Handle attr_accessors on the last line in EmptyLinesAroundAttributeAccessor #9185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Dec 8, 2020
| @@ -47,6 +47,10 @@ def do_something | |||
| RUBY | |||
| end | |||
|
|
|||
| it 'accepts code that where the attr_accessor is the last line' do | |||
| expect_no_offenses("attr_accessor :foo") | |||
There was a problem hiding this comment.
CI is failing. Can you update this one?
Suggested change
| expect_no_offenses("attr_accessor :foo") | |
| expect_no_offenses('attr_accessor :foo') |
There was a problem hiding this comment.
🤦 Too much time in the Chef codebase
…cessor When we're checking the next line and it's nil then there is no next line and the attr_accessor is on the last line. We don't need to pad with an ampty line so we're good at that point and we can continue on with life. Signed-off-by: Tim Smith <tsmith@chef.io>
|
Looks good! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured I should probably push a fix up after writing so many of my own cops. Let me know if I got the process right. I'd like to contribute more fixes for issues we run into at Chef.
The fix:
In Style/EmptyLinesAroundAttributeAccessor we check the line+1 to see if it's empty. That's fine until the attr_accessor is on the last line and then the next line is nil and
blank?fails. When we're checking the next line and it is nil then there is no next line and the attr_accessor is on the last line. We don't need to pad with an empty line so we're good at that point and we can continue on with life.Fixes #9184
Signed-off-by: Tim Smith tsmith@chef.io