[Fix #9174] Handle send nodes with unparenthesized arguments in Style/SoleNestedConditional

[dvandersluis]

If a condition is rewritten by Style/SoleNestedConditional that was an unparenthesized send node, it would be rewritten to a syntax error. This changes it to wrap the send node in parens.

Fixes #9174.

---

Before submitting the PR make sure the following are checked:

• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
• Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

[dvandersluis]

FYI - the original correction, if x && y z would be fixed by Style/MethodCallWithArgsParentheses, and this does work if you run rubocop with --only Style/SoleNestedConditional, Style/MethodCallWithArgsParentheses. However, when the set of cops is not limited like this, Lint/Syntax catches it first and MethodCallWithArgsParentheses is unable to correct the code.

It'd be ideal I think if there was a way to immediately queue up a follow up cop after a cop's autocorrection completes (so that logic doesn't have to be duplicated, but I couldn't find a way to do so.

[dvandersluis]

@koic fixed now, thanks!

[koic]

A little worrisome is that foo && ok?(bar) is (maybe) more natural code rather than foo && (ok? bar) for user 😅

[dvandersluis]

Yeah, I agree, but I couldn't get it working otherwise. If I try to correct the condition node I get a clobbering error. Any suggestions?

[koic]

Unfortunately I don't have an immediate idea 💦 , but I think it can be improved later. First, I'm going to merge this PR to prevent the syntax error. Thank you for your consideration and fixing!

[dvandersluis]

Thanks @koic!