Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9140] Fix an error for Layout/EmptyLinesAroundArguments #9142

Merged

Conversation

koic
Copy link
Member

@koic koic commented Dec 2, 2020

Fixes #9140.

This PR fixes an error for Layout/EmptyLinesAroundArguments when multiline style argument for method call without selector.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Fixes rubocop#9140.

This PR fixes an error for `Layout/EmptyLinesAroundArguments`
when multiline style argument for method call without selector.
@koic koic changed the title [Fix #9141] Fix an error for Layout/EmptyLinesAroundArguments [Fix #9140] Fix an error for Layout/EmptyLinesAroundArguments Dec 2, 2020
@koic koic force-pushed the fix_an_error_for_empty_lines_around_arguments branch from 1cbebc2 to 08d623c Compare December 2, 2020 00:27
@bbatsov bbatsov merged commit 0849d36 into rubocop:master Dec 2, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Dec 2, 2020

Looks good!

@koic koic deleted the fix_an_error_for_empty_lines_around_arguments branch December 2, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running Layout/EmptyLinesAroundArguments cop
2 participants