[Fix #7737] Add new Style/RedundantArguments cop
#9077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejasbubane
force-pushed
the
style-unnecessary-arguments-cop
branch
from
82db332
to
bf38d80
Compare
bbatsov
reviewed
Nov 22, 2020
config/default.yml
Outdated
| Description: 'Check for redundant arguments to methods.' | ||
| Enabled: pending | ||
| Safe: false | ||
| VersionAdded: '1.4' |
There was a problem hiding this comment.
Now we use <<next>> here.
bbatsov
reviewed
Nov 22, 2020
| # split: ' ' | ||
| # foo: 2 | ||
| # | ||
| # Limitations: |
There was a problem hiding this comment.
I'd put those limitations before the configuration examples.
bbatsov
reviewed
Nov 22, 2020
| # | ||
| # @example | ||
| # # bad | ||
| # |
There was a problem hiding this comment.
This blank line is redundant.
bbatsov
reviewed
Nov 22, 2020
| # "first second".split | ||
| # A.foo | ||
| class RedundantArguments < Cop | ||
| MSG = 'Argument is redundant.' |
There was a problem hiding this comment.
I'd expand the message to mention the argument in question and some text saying that the argument is implied by default, so it's clearer what makes it redundant.
tejasbubane
force-pushed
the
style-unnecessary-arguments-cop
branch
from
bf38d80
to
755785a
Compare
|
@bbatsov changes done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7737
Previous PR #7761
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.