Lint/MissingSuper: exclude method_missing and respond_to_missing?
#9072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with the proposed change, but I think it should be clearly explained in the cop's documentation why are those hooks treated differently. |
|
I did my best while staying concise. |
Contrary to the other hooks, these can be completely taken over: ```ruby def method_missing(method, *args) nil end def method_missing(method, *args) delegate_to.send(method, *args) end ``` While a class has a "right" to expect its other hooks to be called, these hooks aren't necessarily called the same way.
|
Looks good! Thanks! |
patbl
added a commit
to academia-edu/linting-config
that referenced
this pull request
Jan 12, 2021
Here are the relevant items from the changelog (https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md): 1. In 0.89.0, "Style/MethodMissingSuper cop is removed in favor of new Lint/MissingSuper cop." 2. rubocop/rubocop#9072 excludes `method_missing` from the the Lint/MissingSuper cop. The reason for (2) was that the "offenses" identified by the cop in `method_missing` definitions were dominated by false positives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to the other hooks, these have very valid cases to be completely taken over:
While a class has a "right" to expect its other hooks to be called, these hooks aren't necessarily called the same way.
From standardrb/standard#195 (comment)