Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lint/UnmodifiedReduceAccumulator to accept blocks which return in the form accumulator[element] #9066

Merged
merged 1 commit into from Nov 18, 2020

Conversation

dvandersluis
Copy link
Member

Reduce blocks that just return something in the form accumulator[element] are now accepted by Lint/UnmodifiedReduceAccumulator (the issue asked for all methods on the accumulator to be allowed but this was the only exception previously due to the check for accumulator index). Other accumulator indexes are still offenses.

Fixes #9059.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@mergify mergify bot merged commit 449a62c into rubocop:master Nov 18, 2020
@dvandersluis dvandersluis deleted the issue/9059 branch January 18, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive of UnmodifiedReduceAccumulator for self
2 participants