[Fix #9032] Fix an error for Style/DocumentDynamicEvalDefinition
#9033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @koic! 😓 |
|
Could this be released as 1.3.1? This is first time for me when |
…ion` Fixes rubocop#9032. This PR fixes an error for `Style/DocumentDynamicEvalDefinition` when using eval-type method with interpolated string that is not heredoc without comment doc. It may be better to provide an option to accept non-heredoc interpolated-string in future.
koic
force-pushed
the
fix_an_error_for_document_dynamic_eval_definition
branch
from
773af9c
to
67e889e
Compare
|
I'll probably cut 1.3.1 later today or tomorrow. There are a couple of other bug-fixes that I'd like to bundle in it. |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Nov 13, 2020
Follow rubocop#9033 (comment) `VersionChanged` has been updated to 1.4 by rubocop#9036, but if the next release is 1.3.1 it will be 1.3 correctly. So I think rubocop#9036 change can be included in the 1.3.1 bugfix release.
8 tasks
bbatsov
pushed a commit
that referenced
this pull request
Nov 13, 2020
Follow #9033 (comment) `VersionChanged` has been updated to 1.4 by #9036, but if the next release is 1.3.1 it will be 1.3 correctly. So I think #9036 change can be included in the 1.3.1 bugfix release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9032.
This PR fixes an error for
Style/DocumentDynamicEvalDefinitionwhen using eval-type method with interpolated string that is not heredoc without comment doc.It may be better to provide an option to accept non-heredoc interpolated-string in future.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.