Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #7966] Enable all pending cops for RuboCop 1.0 #8900

Merged
merged 1 commit into from Oct 16, 2020

Conversation

koic
Copy link
Member

@koic koic commented Oct 16, 2020

Fixes #7966.

This PR enables all pending cops for RuboCop 1.0.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes rubocop#7966.

This PR enables all pending cops for RuboCop 1.0.
@bbatsov bbatsov merged commit 6ac7cd4 into rubocop:master Oct 16, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 16, 2020

We're at the finish line! :-)

@koic koic deleted the enable_pending_cops_to_1_0 branch October 16, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable all pending cops for RuboCop 1.0
2 participants