Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8880] Fix an error for Style/ClassLength #8883

Merged
merged 1 commit into from Oct 12, 2020

Conversation

koic
Copy link
Member

@koic koic commented Oct 10, 2020

Fixes #8880.

This PR fixes an error for Style/ClassLength when overlapping constant assignments.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes rubocop#8880.

This PR fixes an error for `Style/ClassLength`
when overlapping constant assignments.
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 12, 2020

Thanks!

@koic koic deleted the fix_error_for_style_class_length branch October 12, 2020 06:24
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 12, 2020

@koic Please, cut a bugfix release today if you can, as I'm traveling for a couple of days and I won't be able to do this before Thursday.

@koic
Copy link
Member Author

koic commented Oct 12, 2020

@bbatsov I get it! I will cut a bugfix release.

@koic
Copy link
Member Author

koic commented Oct 12, 2020

RuboCop 0.93.1 has been released.
https://github.com/rubocop-hq/rubocop/releases/tag/v0.93.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics/ClassLength cop failing on multi-variable assignment after 0.90.0
2 participants