Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8864] Fix false positive for Style/RedundantBegin with a postfix while or until #8866

Merged
merged 1 commit into from Oct 9, 2020

Conversation

dvandersluis
Copy link
Member

Fixes #8864.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you rebase with the latest master branch?

@dvandersluis
Copy link
Member Author

@koic done!

@koic koic merged commit 45e71c2 into rubocop:master Oct 9, 2020
@koic
Copy link
Member

koic commented Oct 9, 2020

Thanks!

@dvandersluis dvandersluis deleted the issue/8864 branch January 18, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/RedundantBegin does not understand trailing until
2 participants