Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8843] Fix invalid Lint/AmbiguousRegexpLiteral autocorrect when the original node had internal parentheses #8846

Closed
wants to merge 1 commit into from

Conversation

dvandersluis
Copy link
Member

This previously used Util#add_parentheses to do correction, but this does not handle send nodes properly, so I changed it to just edit the node in place.

Fixes #8843.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…ect when the original node had internal parentheses.
@koic
Copy link
Member

koic commented Oct 3, 2020

Thanks for the patch. However, this solution causes incompatibility auto-correction when using method chain.
I opened a PR #8847 that includes a solution to use case of method chain. It seems that we tried to resolve the issue at almost the same timing 😅

@dvandersluis
Copy link
Member Author

@koic great! I'll close this one 😄

@koic
Copy link
Member

koic commented Oct 4, 2020

@dvandersluis I'm sorry about it. Thank you for your activity!

@dvandersluis
Copy link
Member Author

@koic no worries! I’ll keep trying to find more to fix and hopefully we’ll avoid conflicts 😁

@dvandersluis dvandersluis deleted the issue/8843 branch January 18, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint/AmbiguousRegexpLiteral: auto-correction produces invalid code
2 participants