Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-8804] Save actual status to cache #8841

Merged
merged 2 commits into from Oct 5, 2020

Conversation

hatkyinc2
Copy link
Contributor

@hatkyinc2 hatkyinc2 commented Oct 3, 2020

"Unsupported" status should be saved to cache, later to be used by total_correctable_count

This might resolve multiple reports on auto-correct for cops that don't have auto-correct on them

#8804
#8755


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@hatkyinc2
Copy link
Contributor Author

This seems to be the history of it..
d48304e

@bbatsov
Copy link
Collaborator

bbatsov commented Oct 4, 2020

Don't forget to add some changelog entry for this and ideally a test or two.

@hatkyinc2 hatkyinc2 changed the title [Fix-8804] save actual status to cache [Fix-8804] Save actual status to cache, except corrected Oct 5, 2020
@hatkyinc2 hatkyinc2 changed the title [Fix-8804] Save actual status to cache, except corrected [Fix-8804] Save actual status to cache Oct 5, 2020
@hatkyinc2 hatkyinc2 force-pushed the Fix-8804-cache-save-status branch 5 times, most recently from 091f2e8 to b4829e9 Compare October 5, 2020 01:02
* `Unsupported` status should be saved to cache, later to be used by total_correctable_count
* `Corrected` should not be saved to cache [rubocop#5857]
@bbatsov bbatsov merged commit 90997a4 into rubocop:master Oct 5, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 5, 2020

Thanks!

@hatkyinc2 hatkyinc2 deleted the Fix-8804-cache-save-status branch October 5, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants