Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8835] Fix an incorrect autocorrect for Style/RedundantInterpolation #8837

Conversation

koic
Copy link
Member

@koic koic commented Oct 2, 2020

Fixes #8835.

This PR fixes an incorrect autocorrect for Style/RedundantInterpolation when using string interpolation for non-operator methods.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic force-pushed the fix_incorrect_autocorrect_for_redundant_interpolation branch from a13e5f4 to 8e09735 Compare October 2, 2020 17:15
…nterpolation`

Fixes rubocop#8835.

This PR fixes an incorrect autocorrect for `Style/RedundantInterpolation`
when using string interpolation for non-operator methods.
@koic koic force-pushed the fix_incorrect_autocorrect_for_redundant_interpolation branch from 8e09735 to 273bb65 Compare October 5, 2020 03:00
@koic koic merged commit a15f618 into rubocop:master Oct 5, 2020
@koic koic deleted the fix_incorrect_autocorrect_for_redundant_interpolation branch October 5, 2020 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/RedundantInterpolation: auto-correction adds unnecessary parentheses for single method call
3 participants