Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #8718] Fix undefined methods of pseudo location #8823

Merged
merged 5 commits into from Oct 8, 2020
Merged

[Fix #8718] Fix undefined methods of pseudo location #8823

merged 5 commits into from Oct 8, 2020

Commits on Oct 1, 2020

  1. [Fix rubocop#8718] Fix undefined methods of pseudo location 

    This change aims to fix the error due to undefined methods of `RuboCop::Cop::Offence::PseudoSourceRange`.

The `RuboCop::Cop::Offence::PseudoSourceRange` class emulates the `Parser::Source::Range` class in the `parser` gem.
(see <https://github.com/whitequark/parser/blob/v2.7.1.5/lib/parser/source/range.rb>)

The `RuboCop::Cop::Offence#location` attribute can have an instance of both these classes.
So, these classes need to have the same interface and semantics for the usage in RuboCop.
    @ybiquitous
    ybiquitous committed Oct 1, 2020
    Copy the full SHA
    f87c817 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Change end_pos from 1 to 0

    @ybiquitous
    ybiquitous committed Oct 2, 2020
    Copy the full SHA
    7e3b3da View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-pseudo-location

    @ybiquitous
    ybiquitous committed Oct 2, 2020
    Copy the full SHA
    696a076 View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG

    @ybiquitous
    ybiquitous committed Oct 2, 2020
    Copy the full SHA
    64ec21b View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Merge branch 'master' into fix-pseudo-location

    @bbatsov
    bbatsov committed Oct 8, 2020
    Copy the full SHA
    075c98e View commit details
    Browse the repository at this point in the history