[Fix #8782] Mark any condition with defined? as an unsafe autocorrection if it is not parenthesized #8797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the check for
defined?
inunsafe_autocorrect?
only applied when the argument was a single send node with no receiver, but that meant that most timesdefined?
was used in a ternary wrapped in parens, it would be autocorrected incorrectly (sincedefined?
would then be called on the entire ternary instead of the argument). This change makesunsafe_autocorrect?
return true if there is anydefined?
call without parentheses.Fixes #8782.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.