[Fix #8783] Disable Style/ArrayCoercion cop by default
#8792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
disable_style_array_coercion_cop
branch
from
60ea2f5
to
18cb930
Compare
koic
changed the title
Style/ArrayCoercion copStyle/ArrayCoercion cop by default
|
Please, also add some note to the cop description about why it is disabled by default. |
koic
force-pushed
the
disable_style_array_coercion_cop
branch
3 times, most recently
from
d7f2da9
to
ca98c64
Compare
|
Sure! I've added a reason to disable this cop by default to the cop description. |
Fixes rubocop#8783, rubocop#8391, and rubocop#8334. This PR disables `Style/ArrayCoercion` cop by default. Because false positive will occur if the argument of `Array()` is not an array (e.g. Hash, Set), an array will be returned as an incompatibility result.
koic
force-pushed
the
disable_style_array_coercion_cop
branch
from
ca98c64
to
19d4857
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8783, #8391, and #8334.
This PR disables
Style/ArrayCoercioncop. Because false positive will occur if the argument ofArray()is not an array (e.g. Hash, Set), an array will be returned as an incompatibility result.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.