Add callback for rubocop/ast
#8789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading the version first also gives an opportunity for `rubocop/ast` to react. Removing handling of rubocop-ast <1.0 in gemspec no longer needed
marcandre
force-pushed
the
ast_callback
branch
from
eb9485d
to
661506c
Compare
|
@bbatsov sounds ok to you? |
bbatsov
reviewed
Sep 25, 2020
| @@ -8,12 +8,13 @@ | |||
| require 'forwardable' | |||
| require 'regexp_parser' | |||
| require 'unicode/display_width/no_string_ext' | |||
|
|
|||
| require_relative 'rubocop/version' | |||
There was a problem hiding this comment.
I'd add a note here that people should touch this. :-)
bbatsov
approved these changes
Sep 25, 2020
|
Wow! That's quite the dependency tree! 😆 I'll merge this now and cut 0.91.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading the version first also gives an opportunity for
rubocop/astto react.Removing handling of rubocop-ast <1.0 in gemspec no longer needed
See also: rubocop/rubocop-ast#123