Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8764] Fix Layout/CaseIndentation to properly output annotated error messages #8766

Merged

Conversation

dvandersluis
Copy link
Member

find_message is overridden in Layout::CaseIndentation but did not actually annotate the message, so the cop name was not being shown in the output.

Fixes #8764.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@dvandersluis dvandersluis force-pushed the fix-layout-case-indentation-message branch from 7da4caa to 7a10d42 Compare September 22, 2020 17:06
@koic koic merged commit e18f297 into rubocop:master Sep 22, 2020
@koic
Copy link
Member

koic commented Sep 22, 2020

Thank you!

@dvandersluis dvandersluis deleted the fix-layout-case-indentation-message branch January 18, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout/CaseIndentation: the name of rule is not printed in description
2 participants