Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8749] Disable Style/IpAddresses by default in gemfiles and gemspec files #8758

Merged
merged 1 commit into from Sep 22, 2020

Conversation

dvandersluis
Copy link
Member

Fixes #8749.

Not sure if there's a way to test default exclusions so I didn't try to add tests for it but I am happy to if desired.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov bbatsov merged commit 4ed3a2a into rubocop:master Sep 22, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Sep 22, 2020

Looks good! Thanks!

@dvandersluis dvandersluis deleted the fix-style-ipaddresses-exclude branch January 18, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/IpAddresses fails on 4 point version numbers
2 participants