Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect auto-correct for Style/MultilineWhenThen #8750

Merged
merged 1 commit into from Sep 21, 2020

Commits on Sep 21, 2020

  1. Fix an incorrect auto-correct for Style/MultilineWhenThen

    This PR fixes the following incorrect auto-correct for `Style/MultilineWhenThen`
    when line break for multiple condidate values of `when` statement.
    
    ```console
    % cat example.rb
    case condition
    when :foo,
         :bar then nil
    end
    
    % rubocop -a
    (snip)
    
    E
    
    Offenses:
    
    example.rb:3:11: E: Lint/Syntax: unexpected token kNIL
    (Using Ruby 2.7 parser; configure using TargetRubyVersion parameter,
    under AllCops)
         :bar nil
              ^^^
    example.rb:3:11: C: [Corrected] Style/MultilineWhenThen: Do not use then
    for multiline when statement.
         :bar then nil
              ^^^^
    
    1 file inspected, 2 offenses detected, 1 offense corrected
    
    % cat example.rb
    case condition
    when :foo,
         :bar nil
    end
    
    % ruby -c example.rb
    example.rb:3: syntax error, unexpected `nil', expecting `then' or ',' or
    ';' or '\n'
         :bar nil
    ```
    koic committed Sep 21, 2020
    Copy the full SHA
    c5e6105 View commit details
    Browse the repository at this point in the history