Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #8742] Metrics/AbcSize: Fix assignment counts for various cases. #8746

Merged
merged 2 commits into from Sep 20, 2020

Conversation

marcandre
Copy link
Contributor

var += ... was counted twice
obj.method += ... was not counted
Const ||= ... was crashing [#8742]

`var += ...` was counted twice
`obj.method += ...` was not counted
`Const ||= ...` was crashing [rubocop#8742]
@marcandre marcandre changed the title Metrics/AbcSize: Fix assignment counts for various cases. [Fixes #8742] Metrics/AbcSize: Fix assignment counts for various cases. Sep 18, 2020
Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@marcandre marcandre merged commit fbf1966 into rubocop:master Sep 20, 2020
@marcandre marcandre deleted the abcfix branch September 20, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants