[Fix #8372] Fix Lint/RedundantCopEnableDirective
autocorrection not removing empty # rubocop:enable
comments
#8745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second half of the fix for #8372.
Lint/RedundantCopEnableDirective
now determines what directive comments are no longer necessary and removes them outright (ie. when all the cops being enabled are redundant).The
CommentConfig
class had quite a bit going on in it so I extracted a new class I calledRuboCop::DirectiveComment
to encapsulate some logic about determining what cops are present in a directive comment, whichLint/RedundantCopEnableDirective
uses to determine if the entire comment should be removed. There probably is more refactoring that could be done here, but I kept it simple for now.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.