Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8740] Fix a false positive for Style/HashAsLastArrayItem when the hash is in an implicit array #8741

Merged
merged 1 commit into from Sep 17, 2020

Conversation

dvandersluis
Copy link
Member

@dvandersluis dvandersluis commented Sep 16, 2020

Arrays can be passed implicitly to setters, in which case removing the braces causes a syntax error. For example:

config.cache_store = :redis_cache_store, { url: ENV['REDIS_URL'] } 

This change fixes Style/HashAsLastArrayItem to not mark the above as an offense or try to correct it.

Fixes #8740.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic merged commit f1ed705 into rubocop:master Sep 17, 2020
@koic
Copy link
Member

koic commented Sep 17, 2020

Thanks!

@dvandersluis dvandersluis deleted the fix-hash-as-last-array-implicit branch January 18, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for Style/HashAsLastArrayItem when the array is implicit
2 participants