Use token helpers from rubocop-ast #8729
Conversation
| tokens = processed_source.tokens | ||
| begin_index = index_of_first_token(node) | ||
| return unless tokens[begin_index].left_brace? | ||
| begin_index = processed_source.send(:first_token_index, node) |
There was a problem hiding this comment.
We should have made this methods public also, I think.
There was a problem hiding this comment.
Maybe, but I am not sure this is a good example here. Why not call tokens_within, use those and yield those?
There was a problem hiding this comment.
Agreed, updated.
Do you have an idea on why CI fails on windows only?
There was a problem hiding this comment.
Not sure and I've got to run 🏃♂️
There was a problem hiding this comment.
Released 0.4.2; if you bump the requirement this should be good to go 👍
fatkodima
force-pushed
the
rubocop-ast-sorted-tokens
branch
from
228bdd0
to
2414b2f
Compare
| check(tokens[end_index - 1], tokens[end_index]) | ||
| end | ||
| check(tokens[0], tokens[1]) | ||
| check(tokens[-2], tokens[-1]) if tokens.size > 1 |
There was a problem hiding this comment.
Previous condition translates to if tokens.size > 2, no? (technically != 2 but can't be < 2, right?). Still I don't see how that can create an issue, it's just an optimization...
There was a problem hiding this comment.
Changed to > 2, but the same offense.
Funny, that I tested on ruby 2.7 on mac and saw 1 offense on one of the test files, but on CI (non windows) no offenses.
There was a problem hiding this comment.
Ok, finally, I have figured it out - rubocop/rubocop-ast#116
The problem is that sorting is not stable (and this sometimes can change the relative order of tokens like @text="" @pos=123...123 and @text="}" @pos=123..124) and this can lead to incorrect tokens returned by ProcessedSource#tokens_within.
fatkodima
force-pushed
the
rubocop-ast-sorted-tokens
branch
from
2414b2f
to
144f68f
Compare
Followup of #8450
This pr uses new apis from rubocop/rubocop-ast#92
cc @marcandre