[Fix #8726] Fix a false positive for Naming/VariableNumber
#8727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#8726. Fix a false positive for `Naming/VariableNumber` when naming multibyte character variable name.
koic
force-pushed
the
fix_false_positive_for_naming_variable_number
branch
from
e8a7bf3
to
0529b17
Compare
|
Thanks! |
| @@ -98,6 +99,7 @@ def method(funnyArg1); end | |||
| it_behaves_like 'accepts', 'normalcase', '_foo' | |||
| it_behaves_like 'accepts', 'normalcase', '@foo' | |||
| it_behaves_like 'accepts', 'normalcase', '@__foo__' | |||
| it_behaves_like 'accepts', 'snake_case', 'emparejó' | |||
There was a problem hiding this comment.
Should this have been normalcase instead of snake_case?
| @@ -139,6 +141,7 @@ def method(funnyArg_1); end | |||
| it_behaves_like 'accepts', 'non_integer', '_' | |||
| it_behaves_like 'accepts', 'non_integer', '_foo' | |||
| it_behaves_like 'accepts', 'non_integer', '@__foo__' | |||
| it_behaves_like 'accepts', 'snake_case', 'emparejó' | |||
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
Nov 13, 2020
Follow rubocop#8727 (comment) This PR corrects two test cases for `Naming/VariableNumber`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8726.
Fix a false positive for
Naming/VariableNumberwhen naming multibyte character variable name.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.