[#8489] Exclude method respond_to_missing? from OptionalBooleanParameter cop. #8725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcandre
requested changes
Sep 16, 2020
CHANGELOG.md
Outdated
| @@ -45,6 +45,7 @@ | |||
| * [#8500](https://github.com/rubocop-hq/rubocop/issues/8500): Add `in?` to AllowedMethods for `Lint/SafeNavigationChain` cop. ([@tejasbubane][]) | |||
| * [#8629](https://github.com/rubocop-hq/rubocop/pull/8629): Fix the cache being reusable in CI by using crc32 to calculate file hashes rather than `mtime`, which changes each CI build. ([@dvandersluis][]) | |||
| * [#8621](https://github.com/rubocop-hq/rubocop/issues/8621): Add helpful Infinite Loop error message. ([@iSarCasm][]) | |||
| * [#8489](https://github.com/rubocop-hq/rubocop/issues/8489): Exclude method :respond_to_missing? from OptionalBooleanParameter cop. ([@em-gazelle][]) | |||
There was a problem hiding this comment.
Could you please format this as:
Exclude method `respond_to_missing?` from `Style/OptionalBooleanParameter` cop.
There was a problem hiding this comment.
Yes, thank you! Just made the change.
em-gazelle
force-pushed
the
enhancement/exclude_method_in_optional_bool_parameter_cop
branch
from
da914a1
to
2ef9bcd
Compare
…OptionalBooleanParameter cop.
em-gazelle
force-pushed
the
enhancement/exclude_method_in_optional_bool_parameter_cop
branch
from
2ef9bcd
to
2f4a16d
Compare
marcandre
approved these changes
Sep 16, 2020
|
Thank you! 👍 |
|
Great PR indeed! Down the road it might be good to move this list of excluded methods to the cop configuration, so that users can tweak it, but the suggested solution works fine for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops the OptionalBooleanParameter cop from complaining about code calling Ruby's
respond_to_missing?(arg, private = false)method in response to issue 8489.This is currently non-configurable, but I'm happy to modify it if that'd be useful!
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.