[Fix #8710] Fix a false positive for Layout/RescueEnsureAlignment
#8719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
approved these changes
Sep 15, 2020
…ment` Fixes rubocop#8710 and rubocop#8717. This PR fixes a false positive for `Layout/RescueEnsureAlignment` when `Layout/BeginEndAlignment` cop is not enabled status (e.g. pending, disabled). This patch includes workaround for pending status until RuboCop 1.0 is released.
koic
force-pushed
the
fix_false_positive_for_rescue_ensure_alignment
branch
from
dea70b3
to
5b98cfb
Compare
|
Thanks @koic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8710 and #8717.
This PR fixes a false positive for
Layout/RescueEnsureAlignmentwhenLayout/BeginEndAlignmentcop is not enabled status (e.g. pending, disabled).This patch includes workaround for pending status until RuboCop 1.0 is released.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.