Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Lint/UselessMethodDefinition to not register an offense when method definition includes optional arguments #8659

Merged
merged 1 commit into from Sep 7, 2020
Merged

Fix Lint/UselessMethodDefinition to not register an offense when method definition includes optional arguments #8659

merged 1 commit into from Sep 7, 2020

Conversation

fatkodima
Copy link
Contributor

Closes #8561

@fatkodima
Fix Lint/UselessMethodDefinition to not register an offense when me…
c256916 
…thod definition includes optional arguments
@marcandre marcandre merged commit 521d7d6 into rubocop:master Sep 7, 2020
@marcandre
Copy link
Contributor

Great, thanks!

@pirj
Copy link
Member

pirj commented Sep 7, 2020

Thanks!

@pirj pirj mentioned this pull request Sep 7, 2020
Closed
@marcandre marcandre mentioned this pull request Sep 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bquorning bquorning bquorning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint/UselessMethodDefinition false positive with default method arguments
4 participants
@fatkodima @marcandre @pirj @bquorning