[Fix #8470] Do not try to autocorrect Style/StringConcatenation if any of the parts are too complex #8634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @marcandre. |
dvandersluis
force-pushed
the
fix-string-concatenation-autocorrect
branch
2 times, most recently
from
e0e1d54
to
ec69673
Compare
marcandre
reviewed
Sep 3, 2020
dvandersluis
force-pushed
the
fix-string-concatenation-autocorrect
branch
from
ec69673
to
aaf9b21
Compare
…n if any of the parts are too complex. Complex includes multiline statements, heredocs, nested interpolations and expressions with blocks.
dvandersluis
force-pushed
the
fix-string-concatenation-autocorrect
branch
from
aaf9b21
to
eebceb0
Compare
|
@marcandre I added a note in the doc, please let me know if you want me to reword anything! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8470.
If any of the parts in the expression are too complex, an offense will be registered but autocorrection will not take place (ideally the complex expression should be replaced with a variable or method call that could then be interpolated more simply).
The following disable autocorrection:
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.