[Fix #8627] Fix a false positive for Lint/DuplicateRequire
#8631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_false_positive_for_lint_duplicate_require
branch
from
6c1d520
to
c73370a
Compare
|
I think we should also update the examples to make it clearer that this combination is fine. I see right now there are just |
Fixes rubocop#8627. This PR fixes a false positive for `Lint/DuplicateRequire` when same feature argument but different require method.
koic
force-pushed
the
fix_false_positive_for_lint_duplicate_require
branch
from
c73370a
to
2d7d47b
Compare
|
Sure! I added the example! |
marcandre
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8627.
This PR fixes a false positive for
Lint/DuplicateRequirewhen same feature argument but different require method.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.