Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8354] Fix Style/CaseLikeIf to handle regexp named captures #8504

Merged
merged 1 commit into from Oct 2, 2020

Conversation

dmytro-savochkin
Copy link

@dmytro-savochkin dmytro-savochkin commented Aug 10, 2020

Fixes #8354.
Fixes #8541.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@marcandre
Copy link
Contributor

If #8510 is merged first, it would be best to use that instead of doing the parsing with a regexp

@bbatsov
Copy link
Collaborator

bbatsov commented Aug 27, 2020

As it's merged now, I guess we should update this PR.

@dmytro-savochkin
Copy link
Author

As it's merged now, I guess we should update this PR.

updated

@koic
Copy link
Member

koic commented Sep 30, 2020

@dmytro-savochkin This change looks good to me. Can you rebase and update the changelog with the latest master branch? I'm sorry for taking up your time 💦

@dmytro-savochkin
Copy link
Author

@dmytro-savochkin This change looks good to me. Can you rebase and update the changelog with the latest master branch? I'm sorry for taking up your time 💦

@koic, no problem, updated.

@koic koic merged commit 04b9f9e into rubocop:master Oct 2, 2020
@koic
Copy link
Member

koic commented Oct 2, 2020

@dmytro-savochkin Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants