[#8362] Display correctable offenses in summary #8496
Conversation
nguyenquangminh0711
changed the title
| "#{files} inspected, #{offenses} detected, #{corrections} corrected" | ||
| if @correctable_count.positive? | ||
| "#{files} inspected, #{offenses} detected, #{corrections} corrected,"\ | ||
| " #{correctable} correctable" |
There was a problem hiding this comment.
I'd probably use auto-correctable here, so it's clearer we're talking about offenses RuboCop can fix itself.
|
I like a lot the proposed change! Nicely done! I'll likely merge it after cutting 0.89.1, unless someone has any objections. |
|
Great, thanks for your review ❤️. Glad I can help. Btw, do you have any reviews on this @marcandre? Implemented based on your idea in the issue. |
|
Great, thanks for addressing this 😄 |
Good idea! |
|
It looks like it's not every friendly if we have 2 lines stating the same thing. So, I merge into 1 line, and make the language a little bit more natural:
|
CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ | |||
| ### Changes | |||
|
|
|||
| * [#8487](https://github.com/rubocop-hq/rubocop/pull/8487): Detect `<` and `>` as comparison operators in `Style/ConditionalAssignment` cop. ([@biinari][]) | |||
| * [#8362](https://github.com/rubocop-hq/rubocop/issues/8362): Add numbers of correctable offenses to summary. ([@nguyenquangminh0711][]) | |||
There was a problem hiding this comment.
You'll have to move this under master, as I just cut 0.89.1.
There was a problem hiding this comment.
Done. Sorry, I'm not aware that you cut a new relase some couple of hours ago
nguyenquangminh0711
force-pushed
the
feature/display-correctable-offenses-in-summary
branch
from
024bd70
to
fcfe856
Compare
|
Thanks for tackling this! 🙇♂️ |
nguyenquangminh0711
deleted the
feature/display-correctable-offenses-in-summary
branch
|
Thank you @nguyenquangminh0711 for fulfilling my wish! ❤️ |
Solve #8362
When doing investigation only, without
-a. ItWhen running safe corrector:
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.