[Fix #8475] Fix a false positive for Style/HashAsLastArrayItem when t… #8477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Aug 6, 2020
|
This looks good to me. Can you add changelog entry and squash your commits into one? |
…here are duplicate hashes in the array Co-authored-by: Koichi ITO <koic.ito@gmail.com>
|
@koic This is rebased/squashed with the changelog entry added. One set of specs is failing (https://github.com/rubocop-hq/rubocop/pull/8477/checks?check_run_id=959581086), but it doesn't look related to this PR. |
|
It was a false alarm of CI. I re-ran it again and passed it. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8475
The issue is that we were previously comparing values to the last node. If a node equals the last node it will be marked with an offense, when it should not be.