Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #7957] Fix Style/IfUnlessModifier to remain multiline if code after end keyword makes it too long #8449

Merged
merged 1 commit into from Aug 4, 2020

Conversation

dmytro-savochkin
Copy link

Fixes #7957.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…code after end keyword makes it too long
let(:source) do
<<~RUBY
[
1, if foo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really hope that no one actually writes such code. 😆

@bbatsov bbatsov merged commit 4943d50 into rubocop:master Aug 4, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 4, 2020

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop in Style/IfUnlessModifier
2 participants