Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8423] Fix an error for Style/SingleArgumentDig #8426

Merged
merged 1 commit into from Jul 31, 2020

Conversation

koic
Copy link
Member

@koic koic commented Jul 31, 2020

Fixes #8423.

This PR fixes an error for Style/SingleArgumentDig when without a receiver.
This cop wouldn't have to offense when dig method without a receiver.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@tas50
Copy link
Contributor

tas50 commented Jul 31, 2020

Super fast fix. Thanks @koic

Fixes rubocop#8423.

This PR fixes an error for `Style/SingleArgumentDig`
when without a receiver.
This cop wouldn't have to offense when `dig` method without a receiver.
@koic koic force-pushed the fix_error_for_style_single_argument_dig branch from 880f3a7 to cb751c0 Compare July 31, 2020 11:19
@koic koic merged commit cad8d8a into rubocop:master Jul 31, 2020
@koic koic deleted the fix_error_for_style_single_argument_dig branch July 31, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/SingleArgumentDig confuses serverspec for a dig method
3 participants