Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8330] Fix a false positive for Style/MissingRespondToMissing #8421

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jul 31, 2020

Fixes #8330.

This PR fixes a false positive for Style/MissingRespondToMissing when defined method with inline access modifier.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…ssing`

Fixes rubocop#8330.

This PR fixes a false positive for `Style/MissingRespondToMissing`
when defined method with inline access modifier.
@koic koic force-pushed the fix_false_positive_for_missing_respond_to_missing branch from 7cb471e to 731d724 Compare July 31, 2020 01:27
@bbatsov bbatsov merged commit 02daa3d into rubocop:master Jul 31, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Jul 31, 2020

Thanks!

@koic koic deleted the fix_false_positive_for_missing_respond_to_missing branch July 31, 2020 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive with Style/MissingRespondToMissing when using inline access modifiers
2 participants