Add new Layout/EmptyLineAfterMultilineCondition cop
#8411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
changed the title
Layout/EmptyLineAfterMultilineCondition cop
|
To be honest, I've never encountered this style. I think this cop should provide an alternative enforced style option and the default enforced style shouldn't insert a blank line. Or disabled by default. |
fatkodima
force-pushed
the
empty_line_after_multiline_condition-cop
branch
from
124cfeb
to
14586a2
Compare
|
Made this cop disabled. |
|
I'd add a note to AirBnB's guide as a reference and mention this is disable, because that style is not very common in practice. |
fatkodima
force-pushed
the
empty_line_after_multiline_condition-cop
branch
from
14586a2
to
097d5b8
Compare
|
Added reference and note. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8384
This cop will also benefit from #8404 (review) (first paragraph).
@marcandre Friendly ping - have you started work on that? 馃槂