Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor comment access #8405

Merged
merged 9 commits into from Aug 10, 2020
Merged

Refactor comment access #8405

merged 9 commits into from Aug 10, 2020

Commits on Aug 9, 2020

  1. Bump required rubocop-ast

    @marcandre
    marcandre committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    1cb8734 View commit details
    Browse the repository at this point in the history

  2. Remove uses of find_comment

    @marcandre
    marcandre committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    cf4a51c View commit details
    Browse the repository at this point in the history

  3. Avoid use of each_comment

    @marcandre
    marcandre committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    a00c614 View commit details
    Browse the repository at this point in the history

  4. New rubocop-ast insures that ProcessedSource#comments is never nil.

    @marcandre
    marcandre committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    26a1554 View commit details
    Browse the repository at this point in the history

  5. Simplify and optimize comment lookup 

    Highlight for style/safe_navigation_spec isn't perfect though
    @marcandre
    marcandre committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    b6d54a8 View commit details
    Browse the repository at this point in the history

  6. Avoid comments_before_line

    @marcandre
    marcandre committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    d315bab View commit details
    Browse the repository at this point in the history

  7. Fix Style/EmptyCaseCondition's autocorrect. 

    Avoids incorrect use of `comments_before_line`.
The autocorrection worked only for case statements that were root of the document and were not indented
Also fix `Style/SafeNavigation`'s auto-correction, typical off-by-one error without a spec
    @marcandre
    marcandre committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    ffb3f69 View commit details
    Browse the repository at this point in the history

  8. Avoid use of ProcessedSource#commented?

    @marcandre
    marcandre committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    4887c1c View commit details
    Browse the repository at this point in the history

  9. Deprecate comment_lines?

    @marcandre
    marcandre committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    bd66a59 View commit details
    Browse the repository at this point in the history