Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Style/AccessorGrouping to not register offense for accessor with comment #8292

Merged
merged 1 commit into from Jul 10, 2020

Conversation

tejasbubane
Copy link
Contributor

Closes #8289


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov
Copy link
Collaborator

bbatsov commented Jul 9, 2020

@fatkodima Please, take a look as well.

@koic koic merged commit f4151b4 into rubocop:master Jul 10, 2020
@koic
Copy link
Member

koic commented Jul 10, 2020

Thanks!

@tejasbubane tejasbubane deleted the fix-8289 branch July 10, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/AccessorGrouping cop autocorrect mess-up code with comments
4 participants