Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Style/IfUnlessModifier bad precedence detection #8287

Merged
merged 1 commit into from Jul 9, 2020

Conversation

tejasbubane
Copy link
Contributor

Closes #8282


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@marcandre
Copy link
Contributor

LGTM, after @koic's changes are dealt with. 👍

@tejasbubane tejasbubane requested a review from koic July 9, 2020 14:43
@koic koic merged commit e80b278 into rubocop:master Jul 9, 2020
@koic
Copy link
Member

koic commented Jul 9, 2020

Thanks!

@tejasbubane tejasbubane deleted the fix-8282 branch July 9, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/IfUnlessModifier bad precedence detection
3 participants