Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect require block passed as argument in Lint/NonDeterministicRequireOrder #8279

Merged
merged 3 commits into from Jul 13, 2020
Merged

Detect require block passed as argument in Lint/NonDeterministicRequireOrder #8279

merged 3 commits into from Jul 13, 2020

Commits on Jul 8, 2020

  1. Detect require method as arg in Lint/NonDeterministicRequireOrder 

    Detect `&method(:require)` passed as a block argument. For example:

```ruby
Dir[Rails.root.join('spec/support/**/*.rb')].each(&method(:require))

Dir.glob(
  Rails.root.join('spec', 'support', '**', '*.rb'),
  &method(:require)
)
```
    @biinari
    biinari committed Jul 8, 2020
    Copy the full SHA
    80813b5 View commit details
    Browse the repository at this point in the history

  2. Use expect_correction in Lint/NonDeterministicRequireOrder spec

    @biinari
    biinari committed Jul 8, 2020
    Copy the full SHA
    739afb6 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. Merge branch 'master' into feature/require_order_block_pass

    @bbatsov
    bbatsov committed Jul 13, 2020
    Copy the full SHA
    fe066fc View commit details
    Browse the repository at this point in the history