Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for Style/AccessorGrouping when accessors have different access modifiers #8261

Merged
merged 1 commit into from Jul 7, 2020
Merged

Fix false positives for Style/AccessorGrouping when accessors have different access modifiers #8261

merged 1 commit into from Jul 7, 2020

Conversation

fatkodima
Copy link
Contributor

@fatkodima fatkodima commented Jul 7, 2020 •
edited

Closes #8253

This PR:

  1. extracts common functionality for visibility checking into helper module
  2. handles accessor modifiers correctly
  3. handles class << self accessors correctly

@fatkodima fatkodima force-pushed the accessor_grouping-access-modifiers branch from 50d6e03 to 6ec8fb9 Compare July 7, 2020 15:01
@bbatsov bbatsov merged commit caef6bb into rubocop:master Jul 7, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Jul 7, 2020

Great work!

@pat
Copy link
Contributor

pat commented Jul 8, 2020

Thank you for the quick fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style/AccessorGrouping doesn't take access control into account.
3 participants
@fatkodima @bbatsov @pat