Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Style/BisectedAttrAccessor when using attr_reader and attr_writer with splat arguments #8260

Merged
merged 1 commit into from Jul 7, 2020

Conversation

fatkodima
Copy link
Contributor

Closes #8257

@bbatsov
Copy link
Collaborator

bbatsov commented Jul 7, 2020

The changes look good, but your branch has to be rebased on top of the current master branch due to merge conflicts.

@fatkodima fatkodima force-pushed the fix-bisected_attr_accessor-splat branch from 731f3bc to 4796cf1 Compare July 7, 2020 11:11
@fatkodima
Copy link
Contributor Author

Rebased.

@bbatsov bbatsov merged commit 85ff4c3 into rubocop:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/BisectedAttrAccessor cop fails when attr_reader is not used in a normal way
2 participants