[Fix #8256] Fix an error for --auto-gen-config when running a cop without autocorrect
#8258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jul 7, 2020
| @@ -126,6 +125,13 @@ def output_cop_comments(output_buffer, cfg, cop_name, offense_count) | |||
| output_cop_param_comments(output_buffer, params, default_cfg) | |||
| end | |||
|
|
|||
| def support_autocorrect?(cop_name) | |||
| cop_class = Cop::Cop.registry.find_by_cop_name(cop_name) | |||
| return false unless (cop_instance = cop_class&.new) | |||
There was a problem hiding this comment.
I think it will read better if it says unless cop_class here. Then you won't need &. either when you're creating the cop instance.
koic
force-pushed
the
fix_error_for_auto_gen_config_when_running_cop_without_autocorrect
branch
from
7a85438
to
be1912f
Compare
bbatsov
reviewed
Jul 7, 2020
| cop_class = Cop::Cop.registry.find_by_cop_name(cop_name) | ||
| return false unless (cop_instance = cop_class&.new) | ||
|
|
||
| cop_instance.respond_to?(:support_autocorrect?) && cop_instance.support_autocorrect? |
There was a problem hiding this comment.
How come we have cops that don't support this method?
There was a problem hiding this comment.
support_autocorrect? is a class method, so new was not needed 💦
There was a problem hiding this comment.
This is my mistake, I didn't see it. This is new since the Cop refactor.
Thanks @koic
koic
force-pushed
the
fix_error_for_auto_gen_config_when_running_cop_without_autocorrect
branch
2 times, most recently
from
aaecaf3
to
e6ced1f
Compare
…a cop without autocorrect Fixes rubocop#8256. This PR fixes an error for `--auto-gen-config` when running a cop who do not support auto-correction.
koic
force-pushed
the
fix_error_for_auto_gen_config_when_running_cop_without_autocorrect
branch
from
e6ced1f
to
bd2981f
Compare
|
Thanks! |
koic
deleted the
fix_error_for_auto_gen_config_when_running_cop_without_autocorrect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8256.
This PR fixes an error for
--auto-gen-configwhen running a cop who do not support auto-correction.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.